linux-kernel - Re: [PATCH 2/2] scsi: qla2xxx: make msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A65F801A-9D1D-4054-A4D4-C48C9078DF1D@cavium.com>
Date:   Fri, 6 Jan 2017 17:06:58 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>,
        "qla2xxx-upstream@...gic.com" <qla2xxx-upstream@...gic.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] scsi: qla2xxx: make msix_entries const



On 12/26/16, 5:23 AM, "Nicolas Iooss" <nicolas.iooss_linux@....org> wrote:

>msix_entries and qla82xx_msix_entries arrays are never modified in
>drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data.
>
>Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
>---
> drivers/scsi/qla2xxx/qla_isr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
>index 474b415217df..b9c113e47346 100644
>--- a/drivers/scsi/qla2xxx/qla_isr.c
>+++ b/drivers/scsi/qla2xxx/qla_isr.c
>@@ -3003,14 +3003,14 @@ struct qla_init_msix_entry {
> 	irq_handler_t handler;
> };
> 
>-static struct qla_init_msix_entry msix_entries[] = {
>+static const struct qla_init_msix_entry msix_entries[] = {
> 	{ "qla2xxx (default)", qla24xx_msix_default },
> 	{ "qla2xxx (rsp_q)", qla24xx_msix_rsp_q },
> 	{ "qla2xxx (atio_q)", qla83xx_msix_atio_q },
> 	{ "qla2xxx (qpair_multiq)", qla2xxx_msix_rsp_q },
> };
> 
>-static struct qla_init_msix_entry qla82xx_msix_entries[] = {
>+static const struct qla_init_msix_entry qla82xx_msix_entries[] = {
> 	{ "qla2xxx (default)", qla82xx_msix_default },
> 	{ "qla2xxx (rsp_q)", qla82xx_msix_rsp_q },
> };
>@@ -3284,7 +3284,7 @@ qla2x00_free_irqs(scsi_qla_host_t *vha)
> int qla25xx_request_irq(struct qla_hw_data *ha, struct qla_qpair *qpair,
> 	struct qla_msix_entry *msix, int vector_type)
> {
>-	struct qla_init_msix_entry *intr = &msix_entries[vector_type];
>+	const struct qla_init_msix_entry *intr = &msix_entries[vector_type];
> 	scsi_qla_host_t *vha = pci_get_drvdata(ha->pdev);
> 	int ret;
> 
>-- 
>2.11.0
>

Looks Good. 

Acked-By: Himanshu Madhani <himanshu.madhani@...ium.com>

>