linux-kernel - Re: drivers/md/dm-mpath.c:478: suspicious code ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170106200855.GA15627@redhat.com>
Date:   Fri, 6 Jan 2017 15:08:55 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     David Binderman <dcb314@...mail.com>
Cc:     "agk@...hat.com" <agk@...hat.com>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        "shli@...nel.org" <shli@...nel.org>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/md/dm-mpath.c:478: suspicious code ?

On Fri, Jan 06 2017 at 12:52pm -0500,
David Binderman <dcb314@...mail.com> wrote:

> Hello there,
> 
> drivers/md/dm-mpath.c:478:19: warning: decrement of a boolean expression [-Wbool-operation]
> 
> Source code is
> 
>    } while (bypassed--);
> 
> Suggest code rework. Maybe a boolean / int type mixup ?

Yeah, should be cleaned up.

Thanks for reporting this.