linux-kernel - Re: [PATCH v5 3/5] input: Add support for the tm2 touchkey device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH0mkTQ4=_Xs47z95xu5=GEOuj3NW=8EBP8-jnfR0drJHQ@mail.gmail.com>
Date:   Sat, 7 Jan 2017 06:34:36 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Beomho Seo <beomho.seo@...sung.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-input@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        Jaechul Lee <jcsing.lee@...sung.com>,
        Andi Shyti <andi@...zian.org>, Jaechul Lee <galaxyra@...il.com>
Subject: Re: [PATCH v5 3/5] input: Add support for the tm2 touchkey device driver

Hi,

2017-01-06 22:43 GMT+09:00 Andi Shyti <andi.shyti@...sung.com>:
> From: Jaechul Lee <jcsing.lee@...sung.com>
>
> This patch adds the binding description of the tm2 touchkey
> device driver.
>
> Signed-off-by: Jaechul Lee <jcsing.lee@...sung.com>
> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
> Reviewed-by: Andi Shyti <andi.shyti@...sung.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> ---
>  .../bindings/input/samsung,tm2-touchkey.txt        | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/samsung,tm2-touchkey.txt
>
> diff --git a/Documentation/devicetree/bindings/input/samsung,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/samsung,tm2-touchkey.txt
> new file mode 100644
> index 000000000000..4de1af0f0a37
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/samsung,tm2-touchkey.txt
> @@ -0,0 +1,27 @@
> +Samsung tm2-touchkey
> +
> +Required properties:
> +- compatible: must be "samsung,tm2-touchkey"
> +- reg: I2C address of the chip.
> +- interrupt-parent: a phandle for the interrupt controller (see interrupt
> +       binding[0]).
> +- interrupts: interrupt to which the chip is connected (see interrupt
> +       binding[0]).
> +- vcc-supply : internal regulator output. 1.8V
> +- vdd-supply : power supply for IC 3.3V
> +
> +[0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> +Example:
> +       &i2c0 {
> +               /* ... */
> +
> +               touchkey@20 {
> +                       compatible = "samsung,tm2-touchkey";
> +                       reg = <0x20>;
> +                       interrupt-parent = <&gpa3>;
> +                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> +                       vcc-supply=<&ldo32_reg>;
> +                       vdd-supply=<&ldo33_reg>;
> +               };
> +       };

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Chanwoo Choi