linux-kernel - Re: [PATCH] Staging: speakup: styel fix, octal file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170107073945.GA17731@kroah.com>
Date:   Sat, 7 Jan 2017 08:39:45 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Derek Robson <robsonde@...il.com>
Cc:     samuel.thibault@...-lyon.org, w.d.hubbs@...il.com,
        chris@...-brannons.com, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: speakup: styel fix, octal file permissions

On Sat, Jan 07, 2017 at 05:11:16PM +1300, Derek Robson wrote:
> Changed file permission to octal style,
> Found using checkpatch

Typo in your subject line :(

> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  drivers/staging/speakup/kobjects.c | 54 +++++++++++++++++++-------------------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index e744aa9730ff..4e7ebc306488 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -865,66 +865,66 @@ static struct kobj_attribute version_attribute =
>  	__ATTR_RO(version);
>  
>  static struct kobj_attribute delimiters_attribute =
> -	__ATTR(delimiters, S_IWUSR | S_IRUGO, punc_show, punc_store);
> +	__ATTR(delimiters, 0644, punc_show, punc_store);
>  static struct kobj_attribute ex_num_attribute =
> -	__ATTR(ex_num, S_IWUSR | S_IRUGO, punc_show, punc_store);
> +	__ATTR(ex_num, 0644, punc_show, punc_store);

Why not just use __ATTR_RW() for all of these instead?  Be much easier
and smaller and is recommended instead of spelling out the mode values
everywhere.

thanks,

greg k-h