linux-kernel - Re: [PATCH v11 4/8] usb: core: add power sequence handling for USB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170107085616.jvercrfl3huzubkr@kozik-lap>
Date:   Sat, 7 Jan 2017 10:56:16 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Peter Chen <peter.chen@....com>
Cc:     gregkh@...uxfoundation.org, stern@...land.harvard.edu,
        ulf.hansson@...aro.org, broonie@...nel.org, sre@...nel.org,
        robh+dt@...nel.org, shawnguo@...nel.org, rjw@...ysocki.net,
        dbaryshkov@...il.com, heiko@...ech.de,
        linux-arm-kernel@...ts.infradead.org, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, pawel.moll@....com,
        mark.rutland@....com, linux-usb@...r.kernel.org, arnd@...db.de,
        s.hauer@...gutronix.de, mail@...iej.szmigiero.name,
        troy.kisky@...ndarydevices.com, festevam@...il.com,
        oscar@...andei.net, stephen.boyd@...aro.org,
        linux-pm@...r.kernel.org, stillcompiling@...il.com,
        linux-kernel@...r.kernel.org, mka@...omium.org,
        vaibhav.hiremath@...aro.org, gary.bisson@...ndarydevices.com,
        hverkuil@...all.nl, krzk@...nel.org
Subject: Re: [PATCH v11 4/8] usb: core: add power sequence handling for USB
 devices

On Thu, Jan 05, 2017 at 02:01:55PM +0800, Peter Chen wrote:
> Some hard-wired USB devices need to do power sequence to let the
> device work normally, the typical power sequence like: enable USB
> PHY clock, toggle reset pin, etc. But current Linux USB driver
> lacks of such code to do it, it may cause some hard-wired USB devices
> works abnormal or can't be recognized by controller at all.
> 
> In this patch, it calls power sequence library APIs to finish
> the power sequence events. It will do power on sequence at hub's
> probe for all devices under this hub (includes root hub).
> At hub_disconnect, it will do power off sequence which is at powered
> on list.
> 
> Signed-off-by: Peter Chen <peter.chen@....com>
> Tested-by Joshua Clayton <stillcompiling@...il.com>
> Tested-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> Reviewed-by: Vaibhav Hiremath <hvaibhav.linux@...il.com>
> ---
>  drivers/usb/Kconfig    |  1 +
>  drivers/usb/core/hub.c | 48 ++++++++++++++++++++++++++++++++++++++++++++----
>  drivers/usb/core/hub.h |  1 +
>  3 files changed, 46 insertions(+), 4 deletions(-)
> 

Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
Tested on Odroid U3 (reset sequence for LAN9730):
Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof