linux-kernel - Re: [PATCH v2 2/2] ext4: Do not populate extents tree with outdated offsets while shifting extents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170107212746.6bqohlvik7laij7i@thunk.org>
Date:   Sat, 7 Jan 2017 16:27:46 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Roman Pen <roman.penyaev@...fitbricks.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] ext4: Do not populate extents tree with outdated
 offsets while shifting extents

On Fri, Jan 06, 2017 at 09:26:01PM +0100, Roman Pen wrote:
> Inside ext4_ext_shift_extents() function ext4_find_extent() is called
> without EXT4_EX_NOCACHE flag, which should prevent cache population.
> 
> This leads to oudated offsets in the extents tree and wrong blocks
> afterwards.
> 
> Patch fixes the problem providing EXT4_EX_NOCACHE flag for each
> ext4_find_extents() call inside ext4_ext_shift_extents function.
> 
> Signed-off-by: Roman Pen <roman.penyaev@...fitbricks.com>

Thanks, applied.

					- Ted