linux-kernel - [PATCH v2 1/2] Staging: unisys: visorbus: visorbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1a3a2828145dbb71df15da7a247490d02efc4d02.1483826433.git.robsonde@gmail.com>
Date:   Sun,  8 Jan 2017 11:08:01 +1300
From:   Derek Robson <robsonde@...il.com>
To:     david.kershner@...sys.com, gregkh@...uxfoundation.org,
        Timothy.Sell@...sys.com
Cc:     sparmaintainer@...sys.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Derek Robson <robsonde@...il.com>
Subject: [PATCH v2 1/2] Staging: unisys: visorbus: visorbus_main.c: fixed style

Changed file permissions to octal sytle.
Found using checkpatch.

Acked-by: David Kershner <david.kershner@...sys.com>
Signed-off-by: Derek Robson <robsonde@...il.com>
---
Version 1 had duplicated subject/commit message, fixed in v2

 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3457ef338e1e..28ca291a4053 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
 		goto err_hdr_info;
 	}
 	dev->debugfs_client_bus_info =
-		debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+		debugfs_create_file("client_bus_info", 0440,
 				    dev->debugfs_dir, dev,
 				    &client_bus_info_debugfs_fops);
 	if (!dev->debugfs_client_bus_info) {
@@ -1337,10 +1337,10 @@ visorbus_exit(void)
 	debugfs_remove_recursive(visorbus_debugfs_dir);
 }
 
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcematch,
 		 "1 to force a successful dev <--> drv match");
 
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcenomatch,
 		 "1 to force an UNsuccessful dev <--> drv match");
-- 
2.11.0