linux-kernel - Re: [PATCH] perf tools: Create libdir directory before installing libperf-jvmti.so

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 8 Jan 2017 15:24:52 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Create libdir directory before installing
 libperf-jvmti.so

On Fri, Jan 06, 2017 at 02:18:08PM -0800, Laura Abbott wrote:
> The install command for libperf-jvmti.so does not check if libdir exists
> before installing. This means that when the install command is run:
> 
> install libperf-jvmti.so '/tmp/test_root/usr/lib64';
> 
> libperf-jvmti.so will get installed to /usr/lib64 as a file and break further
> installation. Fix this by ensuring the directory gets created first.
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=1410296
> 
> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> For full disclosure, Fedora is setting NO_JVMTI but this should still be fixed
> to allow it to be turned on in the future.

Acked-by: Jiri Olsa <jolsa@...hat.com>

I have patches for fedora to install that, looks like you guys
are not planning to enable it, so I'll post it soon ;-)

thanks,
jirka