[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170108190055.GA14867@krava>
Date: Sun, 8 Jan 2017 20:00:55 +0100
From: Jiri Olsa <jolsa@...hat.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
mingo@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json
files
On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> Handle the Unit field, which is needed to find the right PMU for
> an event. We call it "pmu" and convert it to the perf pmu name
> with an uncore prefix.
>
> Handle the ExtSel field, which just extends the event mask with
> an additional bit.
>
> Handle the Filter field which adds parameters to the main event
> to configure filtering.
>
> Handle the Unit field which declares the unit the values
> should be scaled too (similar to what the kernel exports)
>
> Set up the perpkg field for uncore events so that perf
> knows they are per package (similar to what the kernel exports)
>
> Then output the fields into the pmu-events data structures which
> are compiled into perf.
>
> Filter out zero fields, except for the event itself.
>
> v2: Fix compilation. Add uncore_ prefix at pre-processing time.
> Move eventcode change to separate patch.
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Acked-by: Jiri Olsa <jolsa@...nel.org>
thanks,
jirka
Powered by blists - more mailing lists