linux-kernel - Re: [V1] ata: sata_mv:- Handle return value of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdEdhikycdW=_Hu4wA2mBrgC0bXnrk7=hPnJkeGKxJthA@mail.gmail.com>
Date:   Mon, 9 Jan 2017 00:08:49 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        linux-ide@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.

On Sun, Jan 8, 2017 at 8:49 PM, Tejun Heo <tj@...nel.org> wrote:
> On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
>> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@...nel.org> wrote:
>> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
>> >> Here, If devm_ioremap will fail. It will return NULL.
>> >> Then hpriv->base = NULL - 0x20000; Kernel can run into
>> >> a NULL-pointer dereference. This error check will avoid
>> >> NULL pointer dereference.
>> >>
>> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> >
>> > Applied to libata/for-4.10-fixes.
>>
>> Hold on, why not to convert to devm_ioremap_resource() ?
>
> Care to send the patch?

Incremental or substitute?


-- 
With Best Regards,
Andy Shevchenko