lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 4 Dec 2016 11:39:25 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-kernel@...r.kernel.org, ldewangan@...dia.com
Subject: Re: [PATCH 05/19] staging: iio: isl29028: made alignment of #defines
 consistent

On 04/12/16 02:19, Brian Masney wrote:
> The alignment of the #defines at the top of the file is not consistent.
> This changes all of the defines to use consistent alignment to improve
> the code readability.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Skipped patch 4 for now, but this one still applies fine so applied to the
togreg branch of iio.git.

Will push out as testing later.
> ---
>  drivers/staging/iio/light/isl29028.c | 42 ++++++++++++++++++------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e96a8cb..d5b069e 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -27,38 +27,38 @@
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  
> -#define ISL29028_CONV_TIME_MS		100
> +#define ISL29028_CONV_TIME_MS			100
>  
> -#define ISL29028_REG_CONFIGURE		0x01
> +#define ISL29028_REG_CONFIGURE			0x01
>  
> -#define ISL29028_CONF_ALS_IR_MODE_ALS	0
> -#define ISL29028_CONF_ALS_IR_MODE_IR	BIT(0)
> -#define ISL29028_CONF_ALS_IR_MODE_MASK	BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_ALS		0
> +#define ISL29028_CONF_ALS_IR_MODE_IR		BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_MASK		BIT(0)
>  
> -#define ISL29028_CONF_ALS_RANGE_LOW_LUX	0
> +#define ISL29028_CONF_ALS_RANGE_LOW_LUX		0
>  #define ISL29028_CONF_ALS_RANGE_HIGH_LUX	BIT(1)
> -#define ISL29028_CONF_ALS_RANGE_MASK	BIT(1)
> +#define ISL29028_CONF_ALS_RANGE_MASK		BIT(1)
>  
> -#define ISL29028_CONF_ALS_DIS		0
> -#define ISL29028_CONF_ALS_EN		BIT(2)
> -#define ISL29028_CONF_ALS_EN_MASK	BIT(2)
> +#define ISL29028_CONF_ALS_DIS			0
> +#define ISL29028_CONF_ALS_EN			BIT(2)
> +#define ISL29028_CONF_ALS_EN_MASK		BIT(2)
>  
> -#define ISL29028_CONF_PROX_SLP_SH	4
> -#define ISL29028_CONF_PROX_SLP_MASK	(7 << ISL29028_CONF_PROX_SLP_SH)
> +#define ISL29028_CONF_PROX_SLP_SH		4
> +#define ISL29028_CONF_PROX_SLP_MASK		(7 << ISL29028_CONF_PROX_SLP_SH)
>  
> -#define ISL29028_CONF_PROX_EN		BIT(7)
> -#define ISL29028_CONF_PROX_EN_MASK	BIT(7)
> +#define ISL29028_CONF_PROX_EN			BIT(7)
> +#define ISL29028_CONF_PROX_EN_MASK		BIT(7)
>  
> -#define ISL29028_REG_INTERRUPT		0x02
> +#define ISL29028_REG_INTERRUPT			0x02
>  
> -#define ISL29028_REG_PROX_DATA		0x08
> -#define ISL29028_REG_ALSIR_L		0x09
> -#define ISL29028_REG_ALSIR_U		0x0A
> +#define ISL29028_REG_PROX_DATA			0x08
> +#define ISL29028_REG_ALSIR_L			0x09
> +#define ISL29028_REG_ALSIR_U			0x0A
>  
> -#define ISL29028_REG_TEST1_MODE		0x0E
> -#define ISL29028_REG_TEST2_MODE		0x0F
> +#define ISL29028_REG_TEST1_MODE			0x0E
> +#define ISL29028_REG_TEST2_MODE			0x0F
>  
> -#define ISL29028_NUM_REGS		(ISL29028_REG_TEST2_MODE + 1)
> +#define ISL29028_NUM_REGS			(ISL29028_REG_TEST2_MODE + 1)
>  
>  enum isl29028_als_ir_mode {
>  	ISL29028_MODE_NONE = 0,
> 

Powered by blists - more mailing lists