linux-kernel - Re: [PATCH 2/3] xen: modify xenstore watch event interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a80eb102-8b58-8744-2ce4-57f52437d1be@suse.com>
Date:   Mon, 9 Jan 2017 08:12:36 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org
Cc:     konrad.wilk@...cle.com, roger.pau@...rix.com, wei.liu2@...rix.com,
        paul.durrant@...rix.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface

On 06/01/17 22:57, Boris Ostrovsky wrote:
> On 01/06/2017 10:05 AM, Juergen Gross wrote:
>> Today a Xenstore watch event is delivered via a callback function
>> declared as:
>>
>> void (*callback)(struct xenbus_watch *,
>>                  const char **vec, unsigned int len);
>>
>> As all watch events only ever come with two parameters (path and token)
>> changing the prototype to:
>>
>> void (*callback)(struct xenbus_watch *,
>>                  const char *path, const char *token);
>>
>> is the natural thing to do.
>>
>> Apply this change and adapt all users.
>>
>> Cc: konrad.wilk@...cle.com
>> Cc: roger.pau@...rix.com
>> Cc: wei.liu2@...rix.com
>> Cc: paul.durrant@...rix.com
>> Cc: netdev@...r.kernel.org
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
> 
> 
>>  
>> @@ -903,24 +902,24 @@ static int process_msg(void)
>>  	body[msg->hdr.len] = '\0';
>>  
>>  	if (msg->hdr.type == XS_WATCH_EVENT) {
>> -		msg->u.watch.vec = split(body, msg->hdr.len,
>> -					 &msg->u.watch.vec_size);
>> -		if (IS_ERR(msg->u.watch.vec)) {
>> -			err = PTR_ERR(msg->u.watch.vec);
>> +		if (count_strings(body, msg->hdr.len) != 2) {
>> +			err = -EINVAL;
> 
> xenbus_write_watch() returns -EILSEQ when this type of error is
> encountered so perhaps for we should return the same error here.

Not since 9a6161fe73bdd3ae4a1e18421b0b20cb7141f680. :-)

> 
> Either way
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>

Thanks,

Juergen