linux-kernel - Re: [PATCH v5] PCI: add a new directory for designware core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5873588C.1080809@ti.com>
Date:   Mon, 9 Jan 2017 15:01:56 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>, Arnd Bergmann <arnd@...db.de>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <nsekhar@...com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Minghuan Lian <minghuan.Lian@...escale.com>,
        Mingkai Hu <mingkai.hu@...escale.com>,
        Roy Zang <tie-fei.zang@...escale.com>,
        Richard Zhu <hongxing.zhu@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Murali Karicheri <m-karicheri2@...com>,
        Jingoo Han <jingoohan1@...il.com>,
        Pratyush Anand <pratyush.anand@...il.com>,
        Niklas Cassel <niklas.cassel@...s.com>,
        Jesper Nilsson <jesper.nilsson@...s.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        Gabriele Paoloni <gabriele.paoloni@...wei.com>,
        Stanimir Varbanov <svarbanov@...sol.com>
Subject: Re: [PATCH v5] PCI: add a new directory for designware core

Hi,

On Friday 06 January 2017 07:10 PM, Joao Pinto wrote:
> Hello,
> 
> Às 1:12 PM de 1/6/2017, Kishon Vijay Abraham I escreveu:
>> Hi Arnd,
>>
>> On Friday 06 January 2017 06:31 PM, Arnd Bergmann wrote:
>>> On Friday, January 6, 2017 6:22:48 PM CET Kishon Vijay Abraham I wrote:
>>>> Group all the PCI drivers that use designware core in dwc directory.
>>>> dwc IP is capable of operating in both host mode and device mode and
>>>> keeping it inside the *host* directory is misleading.
>>>
>>> I have no objections to the patch, it makes a lot of sense, but I think
>>> the reasoning above is a bit questionable, as a lot of the other
>>> host drivers (at least tegra, mvebu and xgene, probably more) equally support
>>> endpoint mode and remain in the same directory.
>>>
>>> Any suggestion to what we should do with them?
>>
>> I'm not sure of the exact IP's used by these SoCs. Now that we decided to group
>> the drivers by IPs used, the best would be identify the IPs used in these SoCs
>> and create a separate directory for each of the IPs. If the vendors own IP is
>> used, then create a directory with the name of the vendor?. I'm sure such a
>> change would increase the number of directories but I'm not sure what else to
>> do here.
> 
> In case of designware based drivers you already did the clean up nicely. Next
> would be, like Arnd is sugesting, to do the same to the others. If they are all
> self-contained I suggest we leave them as they are and in the future if a
> endpoint variant driver comes up for any of them, we can suggest to add a folder
> with the vendor or SoC name in order to follow the rule. What do you think?

That's my idea as well. Arnd, do you think it's okay not to disturb other
drivers/directories until endpoint support is added to those drivers?

Thanks
Kishon