linux-kernel - Re: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious code ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1483960583.5227.24.camel@coelho.fi>
Date:   Mon, 09 Jan 2017 13:16:23 +0200
From:   Luca Coelho <luca@...lho.fi>
To:     David Binderman <dcb314@...mail.com>,
        "johannes.berg@...el.com" <johannes.berg@...el.com>,
        "emmanuel.grumbach@...el.com" <emmanuel.grumbach@...el.com>,
        "linuxwifi@...el.com" <linuxwifi@...el.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious
 code ?

On Fri, 2017-01-06 at 17:47 +0000, David Binderman wrote:
> Hello there,

Hi David,


> 1.
> 
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2039:14: warning: decrement of a boolean expression [-Wbool-operation]
> 
> Source code is
> 
>            txq->block--;
> 
> Maybe someone got a bool and a int mixed up ?
> 
> 2.
> 
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2045:14: warning: increment of a boolean expression [-Wbool-operation]
> 
> Duplicate a few lines further down.

Emmanuel has fixed this in our internal tree and I'll be sending it out
together with our normal upstreaming process.

Thanks for reporting!

--
Cheers,
Luca.