linux-kernel - Re: [PATCH v2 1/7] arm: put types.h in uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1990589.0aJHWbJK4F@wuerfel>
Date:   Mon, 09 Jan 2017 12:33:02 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     linuxppc-dev@...ts.ozlabs.org, linux-kbuild@...r.kernel.org
Cc:     Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        linux-mips@...ux-mips.org, alsa-devel@...a-project.org,
        linux-ia64@...r.kernel.org, linux-doc@...r.kernel.org,
        airlied@...ux.ie, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-mtd@...ts.infradead.org,
        sparclinux@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-am33-list@...hat.com,
        linux-c6x-dev@...ux-c6x.org, linux-rdma@...r.kernel.org,
        linux-hexagon@...r.kernel.org, linux-sh@...r.kernel.org,
        coreteam@...filter.org, fcoe-devel@...n-fcoe.org,
        xen-devel@...ts.xenproject.org, linux-snps-arc@...ts.infradead.org,
        linux-media@...r.kernel.org, uclinux-h8-devel@...ts.sourceforge.jp,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-raid@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        openrisc@...ts.librecores.org, linux-metag@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-nfs@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-cris-kernel@...s.com,
        netdev@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        mmarek@...e.com, netfilter-devel@...r.kernel.org,
        linux-alpha@...r.kernel.org, nios2-dev@...ts.rocketboards.org,
        davem@...emloft.net
Subject: Re: [PATCH v2 1/7] arm: put types.h in uapi

On Friday, January 6, 2017 10:43:53 AM CET Nicolas Dichtel wrote:
> 
> diff --git a/arch/arm/include/asm/types.h b/arch/arm/include/asm/types.h
> index a53cdb8f068c..c48fee3d7b3b 100644
> --- a/arch/arm/include/asm/types.h
> +++ b/arch/arm/include/asm/types.h
> @@ -1,40 +1,6 @@
>  #ifndef _ASM_TYPES_H
>  #define _ASM_TYPES_H
>  
> -#include <asm-generic/int-ll64.h>
...
> -#define __UINTPTR_TYPE__       unsigned long
> -#endif
> +#include <uapi/asm/types.h>
>  
>  #endif /* _ASM_TYPES_H */
> 

Moving the file is correct as far as I can tell, but the extra
#include is not necessary here, as the kernel will automatically
search both arch/arm/include/ and arch/arm/include/uapi/.

The same applies to patches 2 and 4.

	Arnd