linux-kernel - Re: [PATCH] spi: spi-axi: Free resources on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a377f44-f548-2167-51bf-4fb46890fae3@metafoo.de>
Date:   Mon, 9 Jan 2017 01:11:44 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        broonie@...nel.org
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spi: spi-axi: Free resources on error path

On 01/09/2017 01:02 AM, Christophe JAILLET wrote:
> We should go to 'err_put_master' here instead of returning directly.
> Otherwise a call to 'spi_master_put' is missing.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks.

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

> ---
>  drivers/spi/spi-axi-spi-engine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
> index 319225d7e761..6ab4c7700228 100644
> --- a/drivers/spi/spi-axi-spi-engine.c
> +++ b/drivers/spi/spi-axi-spi-engine.c
> @@ -494,7 +494,8 @@ static int spi_engine_probe(struct platform_device *pdev)
>  			SPI_ENGINE_VERSION_MAJOR(version),
>  			SPI_ENGINE_VERSION_MINOR(version),
>  			SPI_ENGINE_VERSION_PATCH(version));
> -		return -ENODEV;
> +		ret = -ENODEV;
> +		goto err_put_master;
>  	}
>  
>  	spi_engine->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
>