linux-kernel - Re: [PATCH v2 2/2] platform/x86: fujitsu-laptop: simplify logolamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170109133557.GB31198@marvin.atrad.com.au>
Date:   Tue, 10 Jan 2017 00:05:57 +1030
From:   Jonathan Woithe <jwoithe@...t42.net>
To:     Micha?? K??pie?? <kernel@...pniu.pl>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] platform/x86: fujitsu-laptop: simplify
 logolamp_get()

On Mon, Jan 09, 2017 at 02:14:17PM +0100, Micha?? K??pie?? wrote:
> Now that call_fext_func() is invoked by logolamp_set() for both
> LOGOLAMP_POWERON and LOGOLAMP_ALWAYS for every brightness value,
> logolamp_get() can be simplified to decrease indentation and number of
> local variables.
> 
> Signed-off-by: Micha?? K??pie?? <kernel@...pniu.pl>

Seems sensible to me.

Acked-by: Jonathan Woithe <jwoithe@...t42.net>

> ---
> Changes from v1:
> 
>   - This patch was not present in v1.
>     
> One thing worth noting is that in case call_fext_func() returns an
> error, logolamp_get() will still return LED_OFF, just like the original
> version.
> 
>  drivers/platform/x86/fujitsu-laptop.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 34b8481fb0ed..7fa082558a42 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -319,17 +319,17 @@ static int eco_led_set(struct led_classdev *cdev,
>  
>  static enum led_brightness logolamp_get(struct led_classdev *cdev)
>  {
> -	enum led_brightness brightness = LED_OFF;
> -	int poweron, always;
> -
> -	poweron = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_POWERON, 0x0);
> -	if (poweron == FUNC_LED_ON) {
> -		brightness = LED_HALF;
> -		always = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_ALWAYS, 0x0);
> -		if (always == FUNC_LED_ON)
> -			brightness = LED_FULL;
> -	}
> -	return brightness;
> +	int ret;
> +
> +	ret = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_ALWAYS, 0x0);
> +	if (ret == FUNC_LED_ON)
> +		return LED_FULL;
> +
> +	ret = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_POWERON, 0x0);
> +	if (ret == FUNC_LED_ON)
> +		return LED_HALF;
> +
> +	return LED_OFF;
>  }
>  
>  static enum led_brightness kblamps_get(struct led_classdev *cdev)
> -- 
> 2.11.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--