linux-kernel - Re: [PATCH] ibmvscsis: Fix srp_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6b74ee38-4490-79df-8311-4d7349749cbf@linux.vnet.ibm.com>
Date:   Mon, 9 Jan 2017 11:23:23 -0600
From:   "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     nab@...ux-iscsi.org, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, Bart.VanAssche@...disk.com,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "Bryant G. Ly" <bgly@...ibm.com>
Subject: Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

On 1/9/17 10:47 AM, Greg KH wrote:

> On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote:
>> From: "Bryant G. Ly" <bgly@...ibm.com>
>>
>> If srp_transfer_data fails within ibmvscsis_write_pending, then
>> the most likely scenario is that the client timed out the op and
>> removed the TCE mapping. Thus it will loop forever retrying the
>> op that is pretty much guaranteed to fail forever. A better return
>> code would be EIO instead of EAGAIN.
>>
>> Cc: stable@...r.kernel.org
>> Reported-by: Steven Royer <seroyer@...ux.vnet.ibm.com>
>> Tested-by: Steven Royer <seroyer@...ux.vnet.ibm.com>
>> Signed-off-by: Bryant G. Ly <bgly@...ibm.com>
>> ---
>>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Why are you sending this to me?
>
> confused,
>
> greg k-h
Sorry I meant to put --to target-devel@...r.kernel.org, and just --cc you.

-Bryant