linux-kernel - Re: [PATCH] of: remove redundant memset in overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 10:50:43 -0800
From:   Frank Rowand <frowand.list@...il.com>
To:     YiPing Xu <xuyiping@...ilicon.com>, pantelis.antoniou@...sulko.com,
        robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: remove redundant memset in overlay

Hi Rob,

On 01/07/17 03:04, YiPing Xu wrote:
> From: XuYing <xuyiping@...ilicon.com>
> 
> memset in of_build_overlay_info is redundant, the ovinfo has been
> zeroed in of_fill_overlay_info when error.
> 
> Signed-off-by: YiPing Xu <xuyiping@...ilicon.com>
> ---
>  drivers/of/overlay.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index 0d4cda7..4b1b6b3 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -314,7 +314,6 @@ static int of_build_overlay_info(struct of_overlay *ov,
>  
>  	cnt = 0;
>  	for_each_child_of_node(tree, node) {
> -		memset(&ovinfo[cnt], 0, sizeof(*ovinfo));
>  		err = of_fill_overlay_info(ov, node, &ovinfo[cnt]);
>  		if (err == 0)
>  			cnt++;
> 

Reviewed-by: Frank Rowand <frank.rowand@...sony.com>

I am in the midst of a cleanup of overlay.c.  I can add this patch to
my series if you would prefer.  And of course if I get delayed with
the series I would expect you to apply this one without my series if
you desire.

-Frank