linux-kernel - Re: [PATCH 2/2] nvme: improve cmb sysfs reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1aa7cc9028eab7ebc2a2e9c6bb48e43c.squirrel@webmail.raithlin.com>
Date:   Mon, 9 Jan 2017 13:37:06 -0600
From:   "Stephen Bates" <sbates@...thlin.com>
To:     "Jon Derrick" <jonathan.derrick@...el.com>
Cc:     axboe@...com, sagi@...mberg.me, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        james_p_freyensee@...ux.intel.com
Subject: Re: [PATCH 2/2] nvme: improve cmb sysfs reporting

> Minor nit below
>
>
>> +
>> +	for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++)
>>
> I'd prefer seeing (i = 0; i < ARRAY_SIZE(..); i++) because it provides
> automatic bounds checking against future code.
>

Thanks Jon, I will take a look at doing this in a V1.

Stephen