linux-kernel - Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170109201305.GM12827@mtj.duckdns.org>
Date:   Mon, 9 Jan 2017 15:13:05 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Shaohua Li <shli@...com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, axboe@...com, vgoyal@...hat.com
Subject: Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup

Hello,

On Thu, Dec 15, 2016 at 12:33:00PM -0800, Shaohua Li wrote:
> @@ -1660,6 +1671,11 @@ static bool throtl_tg_can_downgrade(struct throtl_grp *tg)
>  	struct throtl_data *td = tg->td;
>  	unsigned long now = jiffies;
>  
> +	if (time_after_eq(now, tg->last_dispatch_time[READ] +
> +					td->throtl_slice) &&
> +	    time_after_eq(now, tg->last_dispatch_time[WRITE] +
> +					td->throtl_slice))
> +		return false;

So, the duration used here is gonna be made explicitly configurable by
a future patch, right?  Might be worthwhile to note that in the
description.

Thanks.

-- 
tejun