linux-kernel - Re: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc596214-08a4-32b5-aa30-38ddecdf1b48@kernel.dk>
Date:   Mon, 9 Jan 2017 13:41:35 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Omar Sandoval <osandov@...ndov.com>, Jeff Moyer <jmoyer@...hat.com>
Cc:     Markus Pargmann <mpa@...gutronix.de>, linux-block@...r.kernel.org,
        nbd-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        Josef Bacik <jbacik@...com>
Subject: Re: [patch] nbd: blk_mq_init_queue returns an error code on failure,
 not NULL

On 01/09/2017 01:27 PM, Omar Sandoval wrote:
> On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote:
>> Additionally, don't assign directly to disk->queue, otherwise
>> blk_put_queue (called via put_disk) will choke (panic) on the errno
>> stored there.
>>
>> Bug found by code inspection after Omar found a similar issue in
>> virtio_blk.  Compile-tested only.
>>
>> Signed-off-by: Jeff Moyer <jmoyer@...hat.com>
> 
> Reviewed-by: Omar Sandoval <osandov@...com>
> 
> Compile-reviewed only :) Josef can probably test it if he cares enough,
> but it looks right.

Looks good to me, too. Josef, you want me to queue this up directly?

-- 
Jens Axboe