linux-kernel - Re: [PATCH V5 00/17] blk-throttle: add .low limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170109222732.GA35078@shli-mbp.local>
Date:   Mon, 9 Jan 2017 14:27:33 -0800
From:   Shaohua Li <shli@...com>
To:     Tejun Heo <tj@...nel.org>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-team@...com>, <axboe@...com>, <vgoyal@...hat.com>
Subject: Re: [PATCH V5 00/17] blk-throttle: add .low limit

On Mon, Jan 09, 2017 at 04:46:35PM -0500, Tejun Heo wrote:
> Hello,
> 
> Sorry about the long delay.  Generally looks good to me.  Overall,
> there are only a few things that I think should be addressed.

Thanks for your time!
 
> * Low limit should default to zero.

I forgot to change it after changing the name from high to low

> * The default values and roles of idle timeout vs. latency target.
> 
> I don't think either would be difficult to address.  Oh and a bit more
> documentation overall would be nice.

Will fix these.

> Thanks a lot for the great work and happy new year!

Thanks and happy new year!

Best regards,
Shaohua