linux-kernel - Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9325F928-2A19-448A-8C15-1641DF5BBDB0@cavium.com>
Date:   Mon, 9 Jan 2017 23:22:52 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Colin King <colin.king@...onical.com>,
        "qla2xxx-upstream@...gic.com" <qla2xxx-upstream@...gic.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to
 {vendor|hba}_identifer


On 12/29/16, 2:20 PM, "Colin King" <colin.king@...onical.com> wrote:

>From: Colin Ian King <colin.king@...onical.com>
>
>Rename the vendor_indentifer and hba_indentifer fields to correct spelling.
>
>Signed-off-by: Colin Ian King <colin.king@...onical.com>
>---
> drivers/scsi/qla2xxx/qla_def.h | 4 ++--
> drivers/scsi/qla2xxx/qla_gs.c  | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>index f7df01b..ef699b6 100644
>--- a/drivers/scsi/qla2xxx/qla_def.h
>+++ b/drivers/scsi/qla2xxx/qla_def.h
>@@ -2247,7 +2247,7 @@ struct ct_fdmiv2_hba_attr {
> 		uint32_t num_ports;
> 		uint8_t fabric_name[WWN_SIZE];
> 		uint8_t bios_name[32];
>-		uint8_t vendor_indentifer[8];
>+		uint8_t vendor_identifier[8];
> 	} a;
> };
> 
>@@ -2422,7 +2422,7 @@ struct ct_sns_req {
> 		} rsnn_nn;
> 
> 		struct {
>-			uint8_t hba_indentifier[8];
>+			uint8_t hba_identifier[8];
> 		} ghat;
> 
> 		struct {
>diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
>index 94e8a85..ee3df87 100644
>--- a/drivers/scsi/qla2xxx/qla_gs.c
>+++ b/drivers/scsi/qla2xxx/qla_gs.c
>@@ -1939,15 +1939,15 @@ qla2x00_fdmiv2_rhba(scsi_qla_host_t *vha)
> 	/* Vendor Identifier */
> 	eiter = entries + size;
> 	eiter->type = cpu_to_be16(FDMI_HBA_TYPE_VENDOR_IDENTIFIER);
>-	snprintf(eiter->a.vendor_indentifer, sizeof(eiter->a.vendor_indentifer),
>+	snprintf(eiter->a.vendor_identifier, sizeof(eiter->a.vendor_identifier),
> 	    "%s", "QLGC");
>-	alen = strlen(eiter->a.vendor_indentifer);
>+	alen = strlen(eiter->a.vendor_identifier);
> 	alen += 4 - (alen & 3);
> 	eiter->len = cpu_to_be16(4 + alen);
> 	size += 4 + alen;
> 
> 	ql_dbg(ql_dbg_disc, vha, 0x20b1,
>-	    "Vendor Identifier = %s.\n", eiter->a.vendor_indentifer);
>+	    "Vendor Identifier = %s.\n", eiter->a.vendor_identifier);
> 
> 	/* Update MS request size. */
> 	qla2x00_update_ms_fdmi_iocb(vha, size + 16);
>-- 
>2.10.2

Looks good

Acked-by: Himanshu Madhani <himanshu.madhani@...ium.com>
>