linux-kernel - Re: [PATCH 03/12] PM / OPP: Return opp_table from dev_pm_opp_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170109233753.GV17126@codeaurora.org>
Date:   Mon, 9 Jan 2017 15:37:53 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Patrice Chotard <patrice.chotard@...com>,
        linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 03/12] PM / OPP: Return opp_table from dev_pm_opp_set_*()
 routines

On 12/07, Viresh Kumar wrote:
> Now that we have proper kernel reference infrastructure in place for OPP
> tables, use it to guarantee that the OPP table isn't freed while being
> used by the callers of dev_pm_opp_set_*() APIs.
> 
> Make them all return the pointer to the OPP table after taking its
> reference and put the reference back with dev_pm_opp_put_*() APIs.
> 
> Now that the OPP table wouldn't get freed while these routines are
> executing after dev_pm_opp_get_opp_table() is called, there is no need
> to take opp_table_lock. Drop them as well.
> 
> Remove the rcu specific comments from these routines as they aren't
> relevant anymore.
> 
> Note that prototypes of dev_pm_opp_{set|put}_regulators() were already
> updated by another patch.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project