linux-kernel - Re: [PATCH 08/12] PM / OPP: Take kref from _find_opp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170109234958.GZ17126@codeaurora.org>
Date:   Mon, 9 Jan 2017 15:49:58 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 08/12] PM / OPP: Take kref from _find_opp_table()

On 12/07, Viresh Kumar wrote:
> Take reference of the OPP table from within _find_opp_table(). Also
> update the callers of _find_opp_table() to call
> dev_pm_opp_put_opp_table() after they have used the OPP table.
> 
> Note that _find_opp_table() increments the reference under the
> opp_table_lock.
> 
> Now that the OPP table wouldn't get freed until the callers of
> _find_opp_table() call dev_pm_opp_put_opp_table(), there is no need to
> take the opp_table_lock or rcu_read_lock() around it. Drop them.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project