linux-kernel - RE: [char-misc for 4.10-rc4] mei: bus: enable OS version only for SPT and newer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543797E5@hasmsx108.ger.corp.intel.com>
Date:   Tue, 10 Jan 2017 18:12:06 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Chen, Yu C" <yu.c.chen@...el.com>
Subject: RE: [char-misc for 4.10-rc4] mei: bus: enable OS version only for
 SPT and newer

> 
> On Mon, Jan 09, 2017 at 06:15:29PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@...el.com>
> >
> > Sending OS version for support of TPM2_ChangeEPS() is required only
> > for SPT FW (HMB version 2.0) and newer.
> > On older platforms the command should be just ignored by the firmware
> > but some older platforms misbehave so it's safer to send the command
> > only if required.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=192051
> > Fixes: 94a621b0b8aa (mei: send OS type to the FW)
> 
> That's not a valid sha1 :(
> 
> Please fix it up and resend, after figuring out where you got that odd number
> from.

Sorry for that, the sha1 is form our internal branch. 
Will need to add some script that checks that before sending, as that happened in the past already.

Thanks
Tomas