linux-kernel - Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170110182106.7q7uduxxqbzg4squ@lukather>
Date:   Tue, 10 Jan 2017 19:21:06 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.xyz>
Cc:     Chen-Yu Tsai <wens@...e.org>, Stephen Boyd <sboyd@...eaurora.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC

On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote:
> +			uart0_pins_a: uart0@0 {
> +				pins = "PB8", "PB9";
> +				function = "uart0";
> +				bias-pull-up;

Why do you need a pullup here?

Looks good otherwise.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)