linux-kernel - Re: [RFC] coccicheck: add a test for repeat memory fetches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1701101927070.1981@hadrien>
Date:   Tue, 10 Jan 2017 19:28:39 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Kees Cook <keescook@...omium.org>
cc:     cocci@...teme.lip6.fr, Pengfei Wang <wpengfeinudt@...il.com>,
        Vaishali Thakkar <vthakkar1994@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC] coccicheck: add a test for repeat memory fetches

> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2302
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2342
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2365
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2406
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2439
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2491

Do you want the above results?  They have the form:

if (copy_from_user(&t, useraddr, sizeof(t)))

My reasoning was that there could be no problem here, because the size is
the size of the destination structure.  It doesn't depend on user level data.

julia