linux-kernel - Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170110191002.tpdzjlf2eeck4fv6@lukather>
Date:   Tue, 10 Jan 2017 20:10:02 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.xyz>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Andre Przywara <andre.przywara@....com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, Chen-Yu Tsai <wens@...e.org>,
        linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks

On Mon, Jan 09, 2017 at 09:13:12PM +0800, Icenowy Zheng wrote:
> 
> 2017年1月9日 下午7:01于 Maxime Ripard <maxime.ripard@...e-electrons.com>写道：
> >
> > On Fri, Jan 06, 2017 at 06:48:31AM +0800, Icenowy Zheng wrote: 
> > > 
> > > 2017年1月6日 06:04于 Maxime Ripard <maxime.ripard@...e-electrons.com>写道： 
> > > > 
> > > > On Tue, Dec 27, 2016 at 12:25:15AM +0800, Icenowy Zheng wrote: 
> > > > > Add the H5 CCU clocks set based on the H3 one. 
> > > > > 
> > > > > Signed-off-by: Icenowy Zheng <icenowy@...c.xyz> 
> > > > 
> > > > Is there any difference with H3's? 
> > > 
> > > One more Transport Stream controller, so one more bus gate and bus 
> > > reset for it. 
> >
> > There's no need to duplicate more than 1000 lines of code just for 
> > that then. Just add a new compatible and reuse the clocks already 
> > defined. 
> 
> How can I do this? Add them in ccu-sun8i-h3.c ?

Yes, you can have a look at how I did it for sun5i for example if you
want.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)