linux-kernel - Re: [PATCH] staging: android/ion: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1484086369.12006.9.camel@perches.com>
Date:   Tue, 10 Jan 2017 14:12:49 -0800
From:   Joe Perches <joe@...ches.com>
To:     Bogdan Purcareata <bogdan.purcareata@...il.com>,
        labbott@...hat.com, sumit.semwal@...aro.org,
        gregkh@...uxfoundation.org, arve@...roid.com,
        riandrews@...roid.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android/ion: Fix coding style issues

On Tue, 2017-01-10 at 23:40 +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names

Please read Documentation/SubmittingPatches
(umm, make that Documentation/process/submitting-patches.rst)

Make sure to send the patch to yourself only until
you know you can apply it correctly and then send
it to the mailing list.

btw:

This should probably be a series of 4 patches, each
single patch doing one of the things listed above.

And do please use checkpatch on your proposed patches.