linux-kernel - Re: gpio_key.c device tree question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 23:29:11 -0800
From:   noman pouigt <variksla@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: gpio_key.c device tree question

On Sun, Jan 8, 2017 at 7:42 PM, noman pouigt <variksla@...il.com> wrote:
> Hello,
>
> I am trying to see how to disable the sub device nodes in
> gpio_keys device node.
>
> I have this in my base dtsi file:
>
> #include "vendor_file.dtsi"
>
>         gpio_keys {
>                 compatible = "gpio-keys";
>                 input-name = "gpio-keys";
>                 pinctrl-names = "gpio_key_active","gpio_key_suspend";
>                 pinctrl-0 = <&key_active>;
>                 pinctrl-1 = <&key_suspend>;
>                 camera_snapshot {
>                         label = "camera_snapshot";
>                         //snip
>                 };
>         };
>
> I have this in vendor_file.dtsi:
>        gpio_keys {
>                source_key_1 {
>                        label = "source_key_1";
>                        //snip
>                };
>        };
>
> In my current consolidated dtb file all nodes are getting
> added i.e. camera_snapshot and source_key_1. How
> can i remove camera_snapshot node from the
> gpio_keys device node or disable it?

This issue is fixed with below commit:

commit 809d9516da73345cca587743b57e45e9095d851e
Author: Laxman Dewangan <ldewangan@...dia.com>
Date:   Wed Jan 13 00:14:19 2016 -0800

    Input: gpio-keys - allow disabling individual buttons in DT

    Add support to disable buttons from DT via status property if given button
    is not supported on given platforms. This will help re-using existing dtsi
    files across multiple platforms.

    Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>
>
> Thanks,