linux-kernel - Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG2=9p_E6byp0PKY5FUbXgwrN6pwYAxBh40SpDXJSu_yWSBxWQ@mail.gmail.com>
Date:   Tue, 10 Jan 2017 15:37:54 +0800
From:   Chunyan Zhang <zhang.chunyan@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Harjani Ritesh <riteshh@...eaurora.org>,
        Jens Axboe <axboe@...com>, Mike Christie <mchristi@...hat.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()

On 10 January 2017 at 02:31, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring
> <elfring@...rs.sourceforge.net> wrote:
>
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Sun, 8 Jan 2017 18:44:26 +0100
>>
>> * A multiplication for the size determination of a memory allocation
>>   indicated that an array data structure should be processed.
>>   Thus use the corresponding function "kmalloc_array".
>>
>>   This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>>   to make the corresponding size determination a bit safer according to
>>   the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
>
> Chunyan has been running this test code so she might have additional
> insights to provide. I am not aware about anyone else really running the
> tests, are there people who do it?

I talked about mmc_test on #armlinux channel with a person whose
nickname was s84 other day. It seemed that s84 was also trying to use
mmc_test module.

Regards,
Chunyan

>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Yours,
> Linus Walleij