linux-kernel - Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170110081207.GO1555@ZenIV.linux.org.uk>
Date:   Tue, 10 Jan 2017 08:12:07 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhaohongjiang@...wei.com, miaoxie@...wei.com,
        Gu Zheng <guzheng1@...wei.com>
Subject: Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs

On Tue, Jan 10, 2017 at 09:03:01AM +0100, Jan Kara wrote:
> On Mon 09-01-17 09:34:48, Gu Zheng wrote:
> > This change was missed the tmpfs modification in In CVE-2016-7097
> > commit 073931017b49 ("posix_acl: Clear SGID bit when setting
> > file permissions")
> > It can test by xfstest generic/375, which failed to clear
> > setgid bit in the following test case on tmpfs:
> > 
> >   touch $testfile
> >   chown 100:100 $testfile
> >   chmod 2755 $testfile
> >   _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile
> > 
> > Signed-off-by: Gu Zheng <guzheng1@...wei.com>
> 
> Thanks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Al, will you please merge it? Thanks!

Already applied, actually...