linux-kernel - Re: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f115b5c6-9dc2-acb2-1ed8-a0271f8d39cc@rock-chips.com>
Date:   Tue, 10 Jan 2017 16:28:35 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-mmc@...r.kernel.org, Adrian Hunter <adrian.hunter@...el.com>,
        Harjani Ritesh <riteshh@...eaurora.org>,
        Jens Axboe <axboe@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mike Christie <mchristi@...hat.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     shawn.lin@...k-chips.com, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem()

On 2017/1/9 5:50, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 8 Jan 2017 21:43:12 +0100
>
> * The script "checkpatch.pl" pointed information out like the following.
>
>   WARNING: Prefer kcalloc over kzalloc with multiply
>
>   Thus fix the affected source code place.
>

Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>

> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 294d3c675734..cb4750de2720 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
>  	if (!mem)
>  		return NULL;
>
> -	mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs,
> -			   GFP_KERNEL);
> +	mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL);
>  	if (!mem->arr)
>  		goto out_free;
>
>


-- 
Best Regards
Shawn Lin