linux-kernel - RE: [PATCH] ARM: imx: hide unused variable in #ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AMSPR04MB2637CED29E68AA48A81202188670@AMSPR04MB263.eurprd04.prod.outlook.com>
Date:   Tue, 10 Jan 2017 14:53:35 +0000
From:   Frank Li <frank.li@....com>
To:     Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawnguo@...nel.org>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: imx: hide unused variable in #ifdef



> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: Tuesday, January 10, 2017 6:19 AM
> To: Shawn Guo <shawnguo@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Arnd Bergmann
> <arnd@...db.de>; Sascha Hauer <kernel@...gutronix.de>; Fabio Estevam
> <fabio.estevam@....com>; Russell King <linux@...linux.org.uk>; Frank Li
> <frank.li@....com>; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] ARM: imx: hide unused variable in #ifdef
> 
> A bugfix added a new local variable that is only used inside of an #ifdef
> section, and unused if CONFIG_PERF_EVENTS is disabled:
> 
> arch/arm/mach-imx/mmdc.c:63:25: warning: 'cpuhp_mmdc_state' defined
> but not used [-Wunused-variable]
> 
> This moves the variable down inside that same ifdef.
> 
> Fixes: a051f220d6b9 ("ARM/imx/mmcd: Fix broken cpu hotplug handling")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Acked-by: Frank Li <Frank.Li@....com>

>  arch/arm/mach-imx/mmdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
> index 699157759120..c03bf28d8bbc 100644
> --- a/arch/arm/mach-imx/mmdc.c
> +++ b/arch/arm/mach-imx/mmdc.c
> @@ -60,7 +60,6 @@
> 
>  #define to_mmdc_pmu(p) container_of(p, struct mmdc_pmu, pmu)
> 
> -static enum cpuhp_state cpuhp_mmdc_state;  static int ddr_type;
> 
>  struct fsl_mmdc_devtype_data {
> @@ -82,6 +81,7 @@ static const struct of_device_id imx_mmdc_dt_ids[] = {
> 
>  #ifdef CONFIG_PERF_EVENTS
> 
> +static enum cpuhp_state cpuhp_mmdc_state;
>  static DEFINE_IDA(mmdc_ida);
> 
>  PMU_EVENT_ATTR_STRING(total-cycles, mmdc_pmu_total_cycles,
> "event=0x00")
> --
> 2.9.0