linux-kernel - Re: [PATCH] checkpatch: don't warn on every struct without const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484065886.1014.3.camel@sipsolutions.net>
Date:   Tue, 10 Jan 2017 17:31:26 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: don't warn on every struct without
 const_structs file

> > I copied checkpatch elsewhere and ran it.
> 
> Why do you want to copy checkpatch "someplace else"?
> Instead of copy, I think you should soft link it.

Well, no, I have to distribute it with that.

> > Regardless, the current code is utterly stupid - it prints a
> > warning that it won't flag any structs, and then proceeds to flag
> > all structs.
> > 
> > If you must, send a patch to abort() [whatever the perl equivalent
> > is] when the file can't be found, but as it is, the code is just
> > idiotic.
> 
> Maybe so.
> 
> As is, your patch description is incomplete because
> it doesn't mention your use case.

I don't think that's relevant. The script is internally inconsistent,
as I do mention in the commit log, which is worth fixing.

johannes