linux-kernel - Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2017 17:40:51 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Roman Sommer <roman.sommer@....de>
Cc:     linux-kernel@...cs.fau.de, Rui Miguel Silva <rmfrfs@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Christian Bewermeyer <christian.bewermeyer@....de>
Subject: Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to
 unsigned int

On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote:
> From: Christian Bewermeyer <christian.bewermeyer@....de>
> 
> Note that this patch does not fix all checkpatch warnings for
> gpio.c

Fair enough, but you are fixing all of these new "unsigned int"
warnings in that driver, right?

How about fixing the sole remaining instance in the loopback driver so
that this is done for the whole subsystem once and for all?

Also your Subject should be

	staging: greybus: gpio: fix checkpatch unsigned warnings

unless doing this subsystem-wide, in which case you can drop the
"gpio" module prefix.

Thanks,
Johan