linux-kernel - Re: [PATCH 08/12] misc: Flexcard misc device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170110165918.GB19767@kroah.com>
Date:   Tue, 10 Jan 2017 17:59:18 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Holger Dengler <dengler@...utronix.de>
Cc:     Arnd Bergmann <arnd@...db.de>, Lee Jones <lee.jones@...aro.org>,
        Vinod Koul <vinod.koul@...el.com>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Juergen Bubeck <bubeck@...ug.com>,
        Peter Mahler <mahler@...ug.com>,
        Benedikt Spranger <b.spranger@...utronix.de>
Subject: Re: [PATCH 08/12] misc: Flexcard misc device support

On Wed, Dec 14, 2016 at 10:28:25AM +0100, Holger Dengler wrote:
> On 12/14/2016 09:42 AM, Arnd Bergmann wrote:
> > On Wednesday, December 14, 2016 1:11:49 AM CET Holger Dengler wrote:
> >> The Flexcard PCI BAR0 contain registers for configuration but also
> >> for informational purpose like error counter, statistical information
> >> and some timestamps. The read-only mmap of the misc device offers the
> >> userspace a fast access to these registers.
> >>
> >> Signed-off-by: Benedikt Spranger <b.spranger@...utronix.de>
> >> Signed-off-by: Holger Dengler <dengler@...utronix.de>
> >> cc: Arnd Bergmann <arnd@...db.de>
> >> cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> ---
> >>  drivers/mfd/Kconfig          |   1 +
> >>  drivers/misc/Kconfig         |   6 ++
> >>  drivers/misc/Makefile        |   1 +
> >>  drivers/misc/flexcard_misc.c | 165 +++++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 173 insertions(+)
> >>  create mode 100644 drivers/misc/flexcard_misc.c
> >>
> > 
> > Maybe this could fit better in drivers/uio/ than drivers/misc? It
> > seems to only export a memory mapped device.
> 
> You're right, this patch only introduce the memory mapping. But the
> next patch in series add also some attributes to the device, therfore
> we put it in drivers/misc. 

That's fine, it should still be a uio driver as that's what it does.
You can have sysfs files for a UIO device, right?

thanks,

greg k-h