linux-kernel - Re: [PATCH] ibmvscsis: Fix srp_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1484069756.2588.12.camel@sandisk.com>
Date:   Tue, 10 Jan 2017 17:36:11 +0000
From:   Bart Van Assche <Bart.VanAssche@...disk.com>
To:     "bryantly@...ux.vnet.ibm.com" <bryantly@...ux.vnet.ibm.com>
CC:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bgly@...ibm.com" <bgly@...ibm.com>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>
Subject: Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

On Mon, 2017-01-09 at 10:21 -0600, Bryant G. Ly wrote:
> From: "Bryant G. Ly" <bgly@...ibm.com>
> 
> If srp_transfer_data fails within ibmvscsis_write_pending, then
> the most likely scenario is that the client timed out the op and
> removed the TCE mapping. Thus it will loop forever retrying the
> op that is pretty much guaranteed to fail forever. A better return
> code would be EIO instead of EAGAIN.
> 
> Cc: stable@...r.kernel.org
> Reported-by: Steven Royer <seroyer@...ux.vnet.ibm.com>
> Tested-by: Steven Royer <seroyer@...ux.vnet.ibm.com>
> Signed-off-by: Bryant G. Ly <bgly@...ibm.com>
> ---
>  drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index 3d3768a..8fb5c54 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3585,7 +3585,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
>  			       1, 1);
>  	if (rc) {
>  		pr_err("srp_transfer_data() failed: %d\n", rc);
> -		return -EAGAIN;
> +		return -EIO;
>  	}
>  	/*
>  	 * We now tell TCM to add this WRITE CDB directly into the TCM storage

Using the "Cc: stable@...r.kernel.org" tag is fine but please do not
add stable@...r.kernel.org to the CC-list of the e-mail header. Anyway,
thanks for the patch. It has been applied on my for-v4.10 branch.

Bart.