linux-kernel - Re: [PATCH] misc: panel: move LCD_MINOR and KEYPAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170110173736.GB1340@kroah.com>
Date:   Tue, 10 Jan 2017 18:37:36 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     willy@...roxy.com, ksenija.stanojevic@...il.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to
 include/linux/miscdevice.h

On Thu, Dec 15, 2016 at 08:43:52PM +0100, Corentin Labbe wrote:
> This patch move the define for LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h.
> It's better that all minor number definitions are in the same place.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
>  drivers/misc/panel.c       | 3 ---
>  include/linux/miscdevice.h | 2 ++
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/panel.c b/drivers/misc/panel.c
> index 6030ac5..b05c3c7 100644
> --- a/drivers/misc/panel.c
> +++ b/drivers/misc/panel.c
> @@ -61,9 +61,6 @@
>  #include <linux/io.h>
>  #include <linux/uaccess.h>
>  
> -#define LCD_MINOR		156
> -#define KEYPAD_MINOR		185
> -
>  #define PANEL_VERSION		"0.9.5"
>  
>  #define LCD_MAXBYTES		256	/* max burst write */
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index b1ba37aef..7efc045 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -30,9 +30,11 @@
>  #define NVRAM_MINOR		144
>  #define SGI_MMTIMER		153
>  #define STORE_QUEUE_MINOR	155	/* unused */
> +#define LCD_MINOR		156
>  #define I2O_MINOR		166
>  #define HWRNG_MINOR		183
>  #define MICROCODE_MINOR		184
> +#define KEYPAD_MINOR		185
>  #define D7S_MINOR		193
>  #define VFIO_MINOR		196
>  #define TUN_MINOR		200

Doesn't apply to my tree :(