lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Jan 2017 19:11:49 -0800 From: Andy Lutomirski <luto@...capital.net> To: Daniel Borkmann <daniel@...earbox.net> Cc: Andy Lutomirski <luto@...nel.org>, Netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, "Jason A. Donenfeld" <Jason@...c4.com>, Hannes Frederic Sowa <hannes@...essinduktion.org>, Alexei Starovoitov <alexei.starovoitov@...il.com>, Eric Dumazet <edumazet@...gle.com>, Eric Biggers <ebiggers3@...il.com>, Tom Herbert <tom@...bertland.com>, "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org> Subject: Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256 On Tue, Jan 10, 2017 at 4:50 PM, Daniel Borkmann <daniel@...earbox.net> wrote: > On 01/11/2017 12:24 AM, Andy Lutomirski wrote: >> >> This makes it easier to add another digest algorithm down the road if >> needed. It also serves to force any programs that might have been >> written against a kernel that had the old field name to notice the >> change and make any necessary changes. >> >> This shouldn't violate any stable API policies, as no released kernel >> has ever had TCA*BPF_DIGEST. > > > Imho, this and patch 6/8 is not really needed. Should there ever > another digest alg be used (doubt it), then you'd need a new nl > attribute and fdinfo line anyway to keep existing stuff intact. > Nobody made the claim that you can just change this underneath > and not respecting abi for existing applications when I read from > above that such apps now will get "forced" to notice a change. Fair enough. I was more concerned about prerelease iproute2 versions, but maybe that's a nonissue. I'll drop these two patches. --Andy
Powered by blists - more mailing lists