linux-kernel - Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <006ab225-6e16-b1d7-567c-d1f236702589@osg.samsung.com>
Date:   Tue, 10 Jan 2017 21:32:31 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Shuah Khan <shuahkh@....samsung.com>, balbi@...nel.org,
        gregkh@...uxfoundation.org, kgene@...nel.org, krzk@...nel.org
Cc:     linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

Hello Shuah,

On 01/10/2017 09:30 PM, Shuah Khan wrote:

[snip]

>>>  	clk_disable_unprepare(exynos->axius_clk);
>>> +axius_clk_err:
>>
>> This label isn't consistent with the others, I know the errN aren't great
>> so what about changing those to meaningful names in a preparatory patch?
>>
>> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>> Best regards,
>>
> 
> Javier,
> 
> Right they aren't consistent. Changing them all to a better naming scheme
> will have be done in another cleanup patch in my opinion. I don't want to
> include cleanup in this fix.
>

I didn't mean to be done in the same patch, that's why I said in another
preparatory patch.
 
> thanks,
> -- Shuah
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America