linux-kernel - Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <5875C3A6.9040002@samsung.com>
Date:   Wed, 11 Jan 2017 14:33:26 +0900
From:   Inki Dae <inki.dae@...sung.com>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>, robh@...nel.org,
        thierry.reding@...il.com, airlied@...ux.ie, kgene@...nel.org,
        krzk@...nel.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        a.hajda@...sung.com, cw00.choi@...sung.com, jh80.chung@...sung.com
Subject: Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

Applied.

Thanks.

2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글:
> The OF graph is not necessary because the panel is a child of
> dsi. therefore, the parse_dt function of dsi does not need to
> check the remote_node connected to the panel. and the whole
> parse_dt function should be refactored later.
> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 25 +++----------------------
>  1 file changed, 3 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index fed1a94..cf9361a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -269,28 +269,9 @@ static int parse_dt(struct exynos_mic *mic)
>  		}
>  		nodes[j++] = remote_node;
>  
> -		switch (i) {
> -		case ENDPOINT_DECON_NODE:
> -			/* decon node */
> -			if (of_get_child_by_name(remote_node,
> -						"i80-if-timings"))
> -				mic->i80_mode = 1;
> -
> -			break;
> -		case ENDPOINT_DSI_NODE:
> -			/* panel node */
> -			remote_node = get_remote_node(remote_node, 1);
> -			if (!remote_node) {
> -				ret = -EPIPE;
> -				goto exit;
> -			}
> -			nodes[j++] = remote_node;
> -
> -			break;
> -		default:
> -			DRM_ERROR("mic: Unknown endpoint from MIC");
> -			break;
> -		}
> +		if (i == ENDPOINT_DECON_NODE &&
> +			of_get_child_by_name(remote_node, "i80-if-timings"))
> +			mic->i80_mode = 1;
>  	}
>  
>  exit:
>