linux-kernel - Re: Dell XPS13 does not suspend with Linux 4.10-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de>
Date:   Wed, 11 Jan 2017 09:53:38 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Jan Niehusmann <jan@...dor.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Daniel Blueman <daniel@...ra.org>,
        Len Brown <len.brown@...el.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3

Dear Linux folks,


On 01/10/17 23:24, Jan Niehusmann wrote:
> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>> FW"
>
> Indeed, just disabling the FIXUP implemented by that commit fixes
> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>
> (For the addressees newly added to cc, it seems like the mentioned
> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -406,3 +406,3 @@ static struct mei_fixup {
>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>  };
>
>
> I don't know what this may break, as the description of 7279b23 just
> says:
> "This workaround was added to support other broken OS and we need to
> follow here."
>
> Unless there is a better justification, I think the commit should be
> reverted, for now.

Somebody else already created the bug 192051 in the Linux Kernel Bug 
Tracker [1].


Kind regards,

Paul


[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
     "[Bug 192051] [bisected] No hibernation/suspend/shutdown after 
commit 7279b238badec09efd0545293e64c21feee97f73"