linux-kernel - RE: Dell XPS13 does not suspend with Linux 4.10-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5437A141@hasmsx108.ger.corp.intel.com>
Date:   Wed, 11 Jan 2017 09:49:13 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jan Niehusmann <jan@...dor.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Daniel Blueman <daniel@...ra.org>,
        "Brown, Len" <len.brown@...el.com>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>
Subject: RE: Dell XPS13 does not suspend with Linux 4.10-rc3



> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
> 
> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> > On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> 
> >> On 01/10/17 23:24, Jan Niehusmann wrote:
> >>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> >>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
> >>>> to the FW"
> >>>
> >>> Indeed, just disabling the FIXUP implemented by that commit fixes
> >>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >>>
> >>> (For the addressees newly added to cc, it seems like the mentioned
> >>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >>>
> >>> --- a/drivers/misc/mei/bus-fixup.c
> >>> +++ b/drivers/misc/mei/bus-fixup.c
> >>> @@ -406,3 +406,3 @@ static struct mei_fixup {
> >>>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> >>> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>  };
> >>>
> >>>
> >>> I don't know what this may break, as the description of 7279b23 just
> >>> says:
> >>> "This workaround was added to support other broken OS and we need to
> >>> follow here."
> >>>
> >>> Unless there is a better justification, I think the commit should be
> >>> reverted, for now.
> >>
> >> Somebody else already created the bug 192051 in the Linux Kernel Bug
> >> Tracker [1].
> >
> > There's a fix for this in my tree to go to Linus for 4.10-rc4.
> 
> Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
> (9360) now.
> 
> I would have liked if it mentioned suspend issues, and the known broken
> devices in the commit message. That way, I would have found the commit
> more easily.

Yep,  I should probably add that info about the suspend issue, but looks like we broke the whole gen of older devices so we cannot list all of them :(
Tomas