linux-kernel - Re: [PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 11:20:41 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Hanjun Guo <hanjun.guo@...aro.org>,
        Marc Zyngier <marc.zyngier@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     huxinwei@...wei.com, Kefeng Wang <wangkefeng.wang@...wei.com>,
        charles.garcia-tobin@....com, Jon Masters <jcm@...hat.com>,
        yimin@...wei.com, Greg KH <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        Sinan Kaya <okaya@...eaurora.org>, linux-acpi@...r.kernel.org,
        Tomasz Nowicki <tn@...ihalf.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Agustin Vega-Frias <agustinv@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org, Ma Jun <majun258@...wei.com>
Subject: Re: [PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include
 in alphabetic order



On 02/01/17 14:31, Hanjun Guo wrote:
> The head file is strictly in alphabetic order now, so let's
> be the rule breaker. As acpi_iort.h includes acpi.h so remove
> the duplidate acpi.h inclusion as well.
>

Sounds strange, maybe someting like:
Rearrange header file includes to alphabetic order. As acpi_iort.h...

Regards,
Matthias

> Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
> Tested-by: Majun <majun258@...wei.com>
> Tested-by: Xinwei Kong <kong.kongxinwei@...ilicon.com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Tomasz Nowicki <tn@...ihalf.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 69b040f..f471939 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -15,14 +15,13 @@
>   * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>   */
>
> -#include <linux/acpi.h>
> +#include <linux/acpi_iort.h>
>  #include <linux/bitmap.h>
>  #include <linux/cpu.h>
>  #include <linux/delay.h>
>  #include <linux/dma-iommu.h>
>  #include <linux/interrupt.h>
>  #include <linux/irqdomain.h>
> -#include <linux/acpi_iort.h>
>  #include <linux/log2.h>
>  #include <linux/mm.h>
>  #include <linux/msi.h>
>