linux-kernel - Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <7f698df0-f581-7fea-ed2a-762d4a9fcd77@samsung.com>
Date:   Wed, 11 Jan 2017 19:27:10 +0900
From:   hoegeun kwon <hoegeun.kwon@...sung.com>
To:     Andrzej Hajda <a.hajda@...sung.com>, krzk@...nel.org,
        robh@...nel.org, thierry.reding@...il.com, airlied@...ux.ie,
        kgene@...nel.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        inki.dae@...sung.com, cw00.choi@...sung.com,
        jh80.chung@...sung.com, andi.shyti@...sung.com,
        Hyungwon Hwang <human.hwang@...sung.com>,
        Hoegeun Kwon <hoegeun.kwon@...sung.com>
Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel
 device on TM2 board



On 01/11/2017 06:51 PM, hoegeun kwon wrote:
>
>
> On 01/11/2017 04:46 PM, Andrzej Hajda wrote:
>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>> From: Hyungwon Hwang <human.hwang@...sung.com>
>>>
>>> This patch add the panel device tree node for S6E3HA2 display
>>> controller to TM2 dts.
>>>
>>> Signed-off-by: Hyungwon Hwang <human.hwang@...sung.com>
>>> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
>>> Tested-by: Chanwoo Choi <cw00.choi@...sung.com>
>>> ---
>>>   arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>>   1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts 
>>> b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> index ddba2f8..6d362f9 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> @@ -18,6 +18,18 @@
>>>       compatible = "samsung,tm2", "samsung,exynos5433";
>>>   };
>>>   +&dsi {
>>> +    panel@0 {
>>> +        compatible = "samsung,s6e3ha2";
>>> +        reg = <0>;
>>> +        vdd3-supply = <&ldo27_reg>;
>>> +        vci-supply = <&ldo28_reg>;
>>> +        reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>> +        enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>> +        te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>> uses hw-trigger.
>
> Hi Andrzej,
>
> Thanks for your quick review.
>
> Reasonable to remove te-gpios property,
> The Tizen public already has [1] your patch applied and te-gpios removed.
> So I will add [1] to the V9 patch.
>
> [1] 
> https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900

I'm sorry URL address is wrong.
Correct address below:

[1] 
https://git.tizen.org/cgit/platform/kernel/linux-exynos/commit/?h=tizen&id=468769bf6abbaaed2547b8c43e989ab5dc787900

Regards,
Hoegeun

>
> Best Regards,
> Hoegeun
>
>>
>> Regards
>> Andrzej
>>> +    };
>>> +};
>>> +
>>>   &hsi2c_9 {
>>>       status = "okay";
>>
>>
>>
>
>
>