linux-kernel - Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 12:12:26 +0100
From:   Stephan Müller <smueller@...onox.de>
To:     George Cherian <george.cherian@...ium.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        david.daney@...ium.com, clabbe.montjoie@...il.com,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

Am Mittwoch, 11. Januar 2017, 10:56:50 CET schrieb George Cherian:

Hi George,

> +int cvm_enc_dec_setkey(struct crypto_ablkcipher *cipher, const u8 *key,
> +		       u32 keylen)
> +{
> +	struct crypto_tfm *tfm = crypto_ablkcipher_tfm(cipher);
> +	struct cvm_enc_ctx *ctx = crypto_tfm_ctx(tfm);
> +
> +	if ((keylen == 16) || (keylen == 24) || (keylen == 32)) {
> +		ctx->key_len = keylen;
> +		memcpy(ctx->enc_key, key, keylen);
> +		return 0;
> +	}
> +	crypto_ablkcipher_set_flags(cipher, CRYPTO_TFM_RES_BAD_KEY_LEN);
> +
> +	return -EINVAL;
> +}

...
> +
> +struct crypto_alg algs[] = { {
> +	.cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC,
> +	.cra_blocksize = AES_BLOCK_SIZE,
> +	.cra_ctxsize = sizeof(struct cvm_enc_ctx),
> +	.cra_alignmask = 7,
> +	.cra_priority = 4001,
> +	.cra_name = "xts(aes)",
> +	.cra_driver_name = "cavium-xts-aes",
> +	.cra_type = &crypto_ablkcipher_type,
> +	.cra_u = {
> +		.ablkcipher = {
> +			.ivsize = AES_BLOCK_SIZE,
> +			.min_keysize = AES_MIN_KEY_SIZE,
> +			.max_keysize = AES_MAX_KEY_SIZE,
> +			.setkey = cvm_enc_dec_setkey,

May I ask how the setkey for XTS is intended to work? The XTS keys are double 
in size than "normal" keys.

> +			.encrypt = cvm_aes_encrypt_xts,
> +			.decrypt = cvm_aes_decrypt_xts,
> +		},


Ciao
Stephan