linux-kernel - Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 14:01:42 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        julia.lawall@...6.fr, tomi.valkeinen@...com
Subject: Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix


Hi,

On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote:
> The object maxinefb_fix of type fb_fix_screeninfo is never referenced
> after initialization by maxinefb_init. In the init function, the object
> and one of its fields is only stored into another variable. So, the
> object and its fields are never referenced anywhere after initialization
> and therefore add __initdata to its declaration.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Thanks, queued fpr 4.11.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/maxinefb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
> index 5cf52d3..cab7333 100644
> --- a/drivers/video/fbdev/maxinefb.c
> +++ b/drivers/video/fbdev/maxinefb.c
> @@ -51,7 +51,7 @@
>  	.vmode =	FB_VMODE_NONINTERLACED,
>  };
>  
> -static struct fb_fix_screeninfo maxinefb_fix = {
> +static struct fb_fix_screeninfo maxinefb_fix __initdata = {
>  	.id =		"Maxine",
>  	.smem_len =	(1024*768),
>  	.type =		FB_TYPE_PACKED_PIXELS,